Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ast): Make serde optional #7138

Merged
merged 83 commits into from Mar 27, 2023
Merged

refactor(ast): Make serde optional #7138

merged 83 commits into from Mar 27, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 24, 2023

Description:

Turbopack does not use serde of swc AST types.

@kdy1 kdy1 added this to the Planned milestone Mar 24, 2023
@kdy1 kdy1 self-assigned this Mar 24, 2023
@kdy1 kdy1 changed the title refactor(*/ast): Make serde optional refactor(ast): Make serde optional Mar 24, 2023
kdy1
kdy1 commented Mar 24, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_common
  • string_enum --breaking
  • ast_macro --breaking
  • swc_ecma_ast --breaking
  • swc_css_ast --breaking
  • swc_html_ast --breaking
  • swc_xml_ast --breaking

@kdy1 kdy1 mentioned this pull request Mar 24, 2023
Closed
kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 27, 2023
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 27, 2023
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 27, 2023
View reviewed changes
@kdy1 kdy1 disabled auto-merge March 27, 2023 04:28
@kdy1 kdy1 merged commit 30bc086 into swc-project:main Mar 27, 2023
128 of 129 checks passed
@kdy1 kdy1 deleted the serde-opt branch March 27, 2023 04:28
@kdy1 kdy1 mentioned this pull request Mar 27, 2023
Closed
@kdy1 kdy1 modified the milestones: Planned, v1.3.43, v1.3.44 Mar 29, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.44
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kdy1