Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/compat): Handle temporary variable injection position #7171

Merged
merged 2 commits into from Mar 30, 2023
Merged

fix(es/compat): Handle temporary variable injection position #7171

merged 2 commits into from Mar 30, 2023

Conversation

magic-akari
Copy link
Member

Description:

BREAKING CHANGE:

Related issue (if exists):

@magic-akari magic-akari marked this pull request as ready for review March 30, 2023 06:29
kdy1
kdy1 approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_ecma_transforms_compat

@kdy1 kdy1 added this to the Planned milestone Mar 30, 2023
@kdy1 kdy1 enabled auto-merge (squash) March 30, 2023 08:14
swc-bot
swc-bot reviewed Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 disabled auto-merge March 30, 2023 08:41
@kdy1 kdy1 merged commit 23fb8c5 into swc-project:main Mar 30, 2023
14 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.44 Mar 30, 2023
@dleavitt
Copy link

🏎️ !

@ArnaudBarre ArnaudBarre mentioned this pull request Mar 31, 2023
Closed
7 tasks
@magic-akari magic-akari deleted the fix/issue-7169 branch March 31, 2023 07:08
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.44
Development

Successfully merging this pull request may close these issues.

Logical Operator Assignment Generates Invalid Javascript
4 participants
@magic-akari @dleavitt @kdy1 @swc-bot