fix(es/compat): Handle shorthand object prop when rename #7176
+51
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magic-akari
changed the title
magic-akari
changed the title
magic-akari
commented
Mar 30, 2023
crates/swc/tests/tsc-references/intraExpressionInferences.1.normal.js
Outdated
Show resolved
Hide resolved
| @@ -26,6 +26,26 @@ impl VisitMut for Rename { | |||
| } | |||
| } | |||
|
|
|||
| fn visit_mut_prop(&mut self, n: &mut Prop) { | |||
| let span = n.span(); | |||
| if span.ctxt == SyntaxContext::empty() { | |||
There was a problem hiding this comment.
Should I omit this check logic?
There was a problem hiding this comment.
I think this logic can cause a problem
There was a problem hiding this comment.
To skip prop which generated by ourselves.
I noticed that it's the reason caused the test result change.
I will correct it.
swc/crates/swc_ecma_parser/tests/tsc/intraExpressionInferences.ts
Lines 98 to 100 in 6a05c20
kdy1
reviewed
Mar 31, 2023
| @@ -26,6 +26,26 @@ impl VisitMut for Rename { | |||
| } | |||
| } | |||
|
|
|||
| fn visit_mut_prop(&mut self, n: &mut Prop) { | |||
| let span = n.span(); | |||
| if span.ctxt == SyntaxContext::empty() { | |||
There was a problem hiding this comment.
I think this logic can cause a problem
| @@ -26,6 +26,26 @@ impl VisitMut for Rename { | |||
| } | |||
| } | |||
|
|
|||
| fn visit_mut_prop(&mut self, n: &mut Prop) { | |||
| let span = n.span(); | |||
| if span.ctxt == SyntaxContext::empty() { | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
BREAKING CHANGE:
Related issue (if exists):