import '...' with {...}

[arcanis]

Describe the feature

The import '...' assert {...} syntax got changed into import '...' with {...} at the last tc39 meeting.

Babel plugin or link to the feature description

https://github.com/tc39/proposal-import-attributes

Additional context

The purpose of this change was only to explicitly allow runtimes to include the attributes in the module cache key (instead of just validating that the target module was matching the constraint), so it shouldn't need other changes in SWC other than adding support for the new syntax.

[nicolo-ribaudo]

Fyi, Babel is probably going to release support for this next week. I am also working on support for Rollup and Webpack (xtuc/acorn-import-attributes#21). It would be nice to have all the major tools supporting this in the next few months, so that the community can start migrating :)

[kdy1]

This is stage 2, so I'm not going to work on this.

[nicolo-ribaudo]

Its stage 3 pending reviews from other delegates to make sure that the spec text is correct. It already received two out of three reviews (tc39/proposal-import-attributes#137) — I'll ping again when the third one is done because then the proposal will automatically have real stage 3.

[lukastaegert]

@nicolo-ribaudo aren't the reviews done by now?

[nicolo-ribaudo]

I'm sorry, I forgot to ping 😅

This is now been implemented in v8 (flagged) and JSC (unflagged), and is being implemented in TypeScript.

[kdy1]

I'll work on this today or tomorrow

[swc-bot]

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.