Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/modules): Hint nodejs for multiple export * #7184

Merged
merged 2 commits into from
Apr 1, 2023
Merged

fix(es/modules): Hint nodejs for multiple export * #7184

merged 2 commits into from
Apr 1, 2023
+65 −29

Conversation

magic-akari
Copy link
Member

Description:

cjs-module-lexer detection is fragile. Redundant parentheses can cause detection failure.
Therefore, I replaced the sequence expression with a binary expression.

before:

0 && (__export(require("foo")), __export(require("bar")));

after this pull request

0 && __export(require("foo")) &&  __export(require("bar"));

BREAKING CHANGE:

Related issue (if exists):

@magic-akari
fix(es/modules): Hint nodejs for multiple export *
794da85
@magic-akari
refactor

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
529fe13
@magic-akari magic-akari marked this pull request as ready for review April 1, 2023 03:12
kdy1
kdy1 approved these changes Apr 1, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_ecma_transforms_module

@kdy1 kdy1 enabled auto-merge (squash) April 1, 2023 05:40
@kdy1 kdy1 added this to the Planned milestone Apr 1, 2023
@kdy1 kdy1 merged commit 98f1493 into swc-project:main Apr 1, 2023
@kdy1 kdy1 modified the milestones: Planned, v1.3.45 Apr 4, 2023
@magic-akari magic-akari deleted the fix/issue-7180 branch April 7, 2023 02:32
@swc-project swc-project locked as resolved and limited conversation to collaborators May 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.45
Development

Successfully merging this pull request may close these issues.

Can not import named-export from transpiled cjs
2 participants
@magic-akari @kdy1