fix(es/minifier): Don't remove used var decl #7200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Austaras Can you take a look? |
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
|
I believe a more fine grained solution would be most optimal -- the pure mark only marks the function call, but not the call arguments, but here we ignore usage in arguments as well. |
kdy1
commented
Apr 4, 2023
| e.init.visit_with(&mut *self.with_ctx(ctx)); | ||
| self.used_recursively.remove(&id); | ||
|
|
||
| match init { |
There was a problem hiding this comment.
@Austaras Did you mean something like this?
There was a problem hiding this comment.
I can't see changes, seems like they're force pushed.
But these won't really make any real difference, self references are very rarely used. |
jridgewell
approved these changes
Apr 4, 2023
swc-bot
reviewed
Apr 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue:
Uncaught ReferenceErrorwith default minify/compress settings #7194.Invesitgation:
The problematic code is
swc/crates/swc_ecma_usage_analyzer/src/analyzer/mod.rs
Lines 1217 to 1218 in 610e1bb