fix(es/parser): Use a hard error for missing r-paren in an if stmt #7223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
chenyukang
commented
Apr 8, 2023
| @@ -0,0 +1,5 @@ | |||
| const foo = <T extends {}>() => { | |||
There was a problem hiding this comment.
Any better place for this test case?
There was a problem hiding this comment.
chenyukang
commented
Apr 8, 2023
|
|
||
| x An arrow function is not allowed here | ||
| ,-[input.js:1:1] | ||
| 1 | const foo = <T extends {}>() => { |
There was a problem hiding this comment.
I'm trying to understand why this error come out,
I expect we get the same error message as case2.
kdy1
requested changes
Apr 9, 2023
| @@ -0,0 +1,5 @@ | |||
| const foo = <T extends {}>() => { | |||
There was a problem hiding this comment.
chenyukang
force-pushed
the
yukang/fix-7104
branch
from
498c2c9
to
3c4ae6a
Compare
chenyukang
force-pushed
the
yukang/fix-7104
branch
from
3c4ae6a
to
73eb61d
Compare
I moved it to |
kdy1
approved these changes
Apr 10, 2023
kdy1
changed the title
swc-bot
reviewed
Apr 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
BREAKING CHANGE:
Related issue (if exists):
Fixes #7104