Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): parse const type parameters in arrow function expressions #7242

Merged
merged 1 commit into from Apr 11, 2023

Conversation

dsherret
Copy link
Contributor

Ensures code like the following gets parsed as a const type parameter:

export const fn = <const Data extends ReadonlyArray<unknown>>(payload: Data) => payload;

Also if a type parameter is in / out / const incorrectly, the AST should still reflect that while emitting a diagnostic.

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!


swc-bump:

  • swc_ecma_parser

@kdy1 kdy1 enabled auto-merge (squash) April 11, 2023 02:10
@kdy1 kdy1 merged commit 6614886 into swc-project:main Apr 11, 2023
125 of 127 checks passed
@dsherret dsherret deleted the fix_arrow_parsing_const branch April 11, 2023 02:11
@kdy1 kdy1 modified the milestones: Planned, v1.3.50 Apr 13, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants