Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Fix handling of optional chaining when hoist_props is enabled #7246

Merged
merged 8 commits into from Apr 13, 2023
Merged

fix(es/minifier): Fix handling of optional chaining when hoist_props is enabled #7246

merged 8 commits into from Apr 13, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Apr 11, 2023

@kdy1 kdy1 added this to the Planned milestone Apr 11, 2023
@kdy1 kdy1 self-assigned this Apr 11, 2023
@kdy1 kdy1 requested a review from jridgewell April 11, 2023 05:29
@kdy1 kdy1 marked this pull request as ready for review April 11, 2023 05:29
kdy1
kdy1 commented Apr 11, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

@kdy1 kdy1 changed the title fix(es/minifier): Fix hoist_props fix(es/minifier): Fix handling of optional chaining when hoist_props is enabled Apr 11, 2023
@kdy1 kdy1 enabled auto-merge (squash) April 13, 2023 02:35
swc-bot
swc-bot reviewed Apr 13, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit a44fea1 into swc-project:main Apr 13, 2023
128 checks passed
@kdy1 kdy1 deleted the issue-7228 branch April 13, 2023 03:23
@kdy1 kdy1 modified the milestones: Planned, v1.3.50 Apr 13, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

@jridgewell jridgewell Awaiting requested review from jridgewell

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.50
Development

Successfully merging this pull request may close these issues.

"hoist_props" results in incorrect code when optional-chaining with brackets
2 participants
@kdy1 @swc-bot