Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump bitflags #7270

Merged
merged 3 commits into from
Apr 15, 2023
Merged

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Apr 14, 2023

Description:

  1. napi-rs has been updated bitflags to 2.1.x , https://github.com/napi-rs/napi-rs/blob/main/crates/napi/Cargo.toml#L58, for now, swc still use 1.x, when a downstream app dependends on both swc and napi-rs it may be leads to multiple version bitflags exists in Cargo.lock
  2. Also, reducing multiple versions of bitflags would reduce compile time.

BREAKING CHANGE:

Related issue (if exists):

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review April 14, 2023 17:48
@kdy1 kdy1 added this to the Planned milestone Apr 14, 2023
@@ -240,6 +240,12 @@ version = "1.3.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "bef38d45163c2f1dde094a7dfd33ccf595c92905c8f8f4fdc18d06fb1037718a"

[[package]]
name = "bitflags"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like bitflags is now included two times

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try to investigate that issue.

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_common

@kdy1 kdy1 enabled auto-merge (squash) April 14, 2023 23:06
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit c4cce12 into swc-project:main Apr 15, 2023
@IWANABETHATGUY IWANABETHATGUY deleted the chore/bump-bitflags branch April 15, 2023 03:28
@kdy1 kdy1 modified the milestones: Planned, v1.3.51 Apr 15, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants