feat(swc): enable bytecheck #7280
Merged
+156
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
previously approved these changes
Apr 19, 2023
|
@kdy1 Resolved conflict, I think we can land this now (which.. requires another bump for swc_core and @swc/core probably though) |
|
@kdy1 thoughts on this? I think this is now ready to go in. |
|
I agree, but I'm curious if this is a breaking change of |
|
I may wrong, but I guess not? This PR enables |
kdy1
approved these changes
May 6, 2023
swc-bot
reviewed
May 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Second attempt to enable bytecheck. This PR does not have cersioned struct yet, just enabling bytecheck whereever possible. Also it is for the ast only yet, so transformmetadata and other might need this later.
PR seems to passing all the ci, but as we've experienced before there might be some unexpected outcome with release. Maybe better to hold this until clear #7238, then land as separate release.