Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(es/react): Don't use regex #7284

Merged
merged 4 commits into from
Apr 18, 2023
Merged

perf(es/react): Don't use regex #7284

merged 4 commits into from
Apr 18, 2023
+11 −12

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Apr 18, 2023

Description:

It's causing a performance problem in concurrent scenarios.

x-ref: https://linear.app/vercel/issue/WEB-921
x-ref: https://vercel.slack.com/archives/C02HY34AKME/p1681757237489689

Related issue:

@kdy1 kdy1 added this to the Planned milestone Apr 18, 2023
@kdy1 kdy1 self-assigned this Apr 18, 2023
kdy1
kdy1 commented Apr 18, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_react

@kdy1 kdy1 marked this pull request as ready for review April 18, 2023 01:53
@kdy1 kdy1 enabled auto-merge (squash) April 18, 2023 01:53
@kdy1 kdy1 merged commit 248fd37 into swc-project:main Apr 18, 2023
@kdy1 kdy1 deleted the regex branch April 18, 2023 02:45
@kdy1 kdy1 modified the milestones: Planned, v1.3.52 Apr 19, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators May 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq[bot]

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.52
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kdy1