Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix path normalization on windows for testing diffs #7299

Merged
merged 1 commit into from Apr 19, 2023
Merged

fix path normalization on windows for testing diffs #7299

merged 1 commit into from Apr 19, 2023

Conversation

ForsakenHarmony
Copy link
Contributor

Description:

This makes sure that even if there's a windows path with / it still gets picked up

Example: "C:/User/test/Code/project/src/f.js" -> "$DIR/src/f.js"

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

kdy1
kdy1 approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • testing

@kdy1 kdy1 added this to the Planned milestone Apr 19, 2023
@kdy1 kdy1 enabled auto-merge (squash) April 19, 2023 21:52
@kdy1 kdy1 merged commit 3422923 into swc-project:main Apr 19, 2023
126 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.53 Apr 21, 2023
@ForsakenHarmony ForsakenHarmony deleted the hrmny/fix-windows-normalization branch April 25, 2023 18:40
@swc-project swc-project locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.53
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ForsakenHarmony @CLAassistant @kdy1