Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(es/parser): Implement explicit resource management #7322

Merged
merged 80 commits into from
May 10, 2023
Merged

feat(es/parser): Implement explicit resource management #7322

merged 80 commits into from
May 10, 2023
+2,057 −125

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Apr 24, 2023 •
edited
Loading

Description:

  • Add UsingDecl.
  • Add UsingDecl to Decl.
  • Rename VarDeclOrPat to ForHead.
  • Add UsingDecl to ForHead.
  • Implement parser for using declarations.

Related issue:

@kdy1 kdy1 added this to the Planned milestone Apr 24, 2023
@kdy1 kdy1 self-assigned this Apr 24, 2023
kdy1
kdy1 commented Apr 24, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_atoms
  • swc_ecma_ast --breaking

magic-akari
magic-akari reviewed Apr 24, 2023
View reviewed changes
crates/swc_atoms/words.txt
@@ -870,8 +870,8 @@ XPathExpression
XPathResult
XSLTProcessor
__proto__
_define_property
_defineProperty
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to remove _defineProperty now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically it's a breaking change because js_word!("_defineProperty") will not compile anymore, but I think it's fine.

@kdy1 kdy1 force-pushed the explicit-resource-mangement branch from 4adcc95 to 52e6c60 Compare April 25, 2023 01:59
@kdy1 kdy1 mentioned this pull request May 9, 2023
Closed
@kdy1 kdy1 marked this pull request as ready for review May 10, 2023 03:28
kodiakhq[bot]
kodiakhq bot previously approved these changes May 10, 2023
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) May 10, 2023 03:30
swc-bot
swc-bot reviewed May 10, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed May 10, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 disabled auto-merge May 10, 2023 03:45
@kdy1 kdy1 enabled auto-merge (squash) May 10, 2023 03:46
@kdy1 kdy1 merged commit 041b491 into swc-project:main May 10, 2023
@kdy1 kdy1 deleted the explicit-resource-mangement branch May 10, 2023 04:16
@l4yton
Copy link
Contributor

l4yton commented May 12, 2023

Stumbled upon this PR after updating swc and wondering what UsingDecl is. If it is a typescript specific type, wouldn't it make sense to name it TsUsingDecl to be in line with the current naming scheme of prefixing these types with Ts?

@kdy1 kdy1 modified the milestones: Planned, v1.3.58 May 15, 2023
@punkeel punkeel mentioned this pull request May 15, 2023
Closed
@IWANABETHATGUY IWANABETHATGUY mentioned this pull request May 24, 2023
Closed
@swc-project swc-project locked as resolved and limited conversation to collaborators Jun 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@magic-akari magic-akari

@swc-bot swc-bot

@kodiakhq kodiakhq[bot]

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.58
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kdy1 @l4yton @magic-akari @swc-bot