Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin execution fails if plugin binary enables LTO #7479

Closed
kwonoj opened this issue Jun 2, 2023 · 3 comments
Closed

Plugin execution fails if plugin binary enables LTO #7479

kwonoj opened this issue Jun 2, 2023 · 3 comments
Assignees
@kwonoj
Labels
A: plugin C-bug

Comments

@kwonoj
Copy link
Member

kwonoj commented Jun 2, 2023

Describe the bug

For the tracking purpose.

After recent upgrade to wasmer@3, we are observing plugin execution failure if the plugin binary is compiled with LTO enabled.

We do not have any clue yet - just know disabling lto makes it work in general.

Input code

No response

Config

No response

Playground link

No response

Expected behavior

Do not panic / crash

Actual behavior

No response

Version

@latest

Additional context

No response
@kwonoj kwonoj self-assigned this Jun 2, 2023
@kwonoj kwonoj changed the title Plugin execute fails if plugin binary enables LTO Plugin execution fails if plugin binary enables LTO Jun 2, 2023
@kdy1 kdy1 pinned this issue Jun 5, 2023
@victorandree victorandree mentioned this issue Aug 11, 2023
Open
8 tasks
victorandree added a commit to victorandree/graphql-code-generator that referenced this issue Aug 15, 2023
@victorandree
Update swc_core to v0.79
517fcc4 
This allows the swc-plugin to work with Next.js v13.4.10, or later, as
documented on https://swc.rs/docs/plugin/selecting-swc-core.

As part of upgrading, we also set `lto = false` because of build
failures that have been popped up
(swc-project/swc#7479).

Closes: dotansimha#9450
@kwonoj kwonoj mentioned this issue Sep 11, 2023
Closed
@niieani
Copy link

niieani commented Sep 11, 2023 •
edited

Thanks @kwonoj for referring me here. Based on my experience, it seems like we do have a clue now.
The plugin seems to work with LTO enabled, as long as metadata.get_transform_plugin_config() isn't called.
It seems that this is in some way responsible for the crash.

@nil1511 nil1511 mentioned this issue Sep 19, 2023
Closed
victorandree added a commit to victorandree/graphql-code-generator that referenced this issue Sep 28, 2023
@victorandree
Update swc_core to v0.79
d8bdae3 
This allows the swc-plugin to work with Next.js v13.4.10, or later, as
documented on https://swc.rs/docs/plugin/selecting-swc-core.

As part of upgrading, we also set `lto = false` because of build
failures that have been popped up (swc-project/swc#7479).

Closes: dotansimha#9450
leegeunhyeok added a commit to leegeunhyeok/swc-plugin-react-refresh that referenced this issue Oct 21, 2023
@leegeunhyeok
fix: plugin execution fails on release build
5a38974 
Disable LTO on release build.

refs swc-project/swc#7479
victorandree added a commit to victorandree/graphql-code-generator that referenced this issue Nov 16, 2023
@victorandree
Update swc_core to v0.79
e6cb081 
This allows the swc-plugin to work with Next.js v13.4.10, or later, as
documented on https://swc.rs/docs/plugin/selecting-swc-core.

As part of upgrading, we also set `lto = false` because of build
failures that have been popped up (swc-project/swc#7479).

Closes: dotansimha#9450
@kwonoj kwonoj mentioned this issue Jan 23, 2024
Closed
@medfreeman medfreeman mentioned this issue Jan 26, 2024
Open
8 tasks
@kdy1
Copy link
Member

kdy1 commented May 8, 2024

I think this issue can be closed as we updated wasmer to v4.2.5 with #8624

@kdy1 kdy1 closed this as completed May 8, 2024
@kdy1 kdy1 unpinned this issue May 8, 2024
@kdy1
Copy link
Member

kdy1 commented May 8, 2024

Note: The official plugins use LTO.

https://github.com/swc-project/plugins/blob/2324cb2aec86c2fa0cdd528f0edc7743cf259a86/Cargo.toml#L34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kwonoj kwonoj

Labels
A: plugin C-bug
Milestone
No milestone
Development

No branches or pull requests
3 participants
@niieani @kwonoj @kdy1