Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/codegen): Remove extra spaces in AssignPatProp and KeyValuePatProp #7488

Merged
merged 7 commits into from
Jun 7, 2023
Merged

fix(es/codegen): Remove extra spaces in AssignPatProp and KeyValuePatProp #7488

merged 7 commits into from
Jun 7, 2023
+933 −934

Conversation

dsherret
Copy link
Contributor

@dsherret dsherret commented Jun 4, 2023

No description provided.

@dsherret
Copy link
Contributor Author

dsherret commented Jun 5, 2023

I'm not sure what's up with the swc tests. I always get: Lazy instance has previously been poisoned locally

@kwonoj
Copy link
Member

kwonoj commented Jun 5, 2023

I'm not sure what's up with the swc tests. I always get: Lazy instance has previously been poisoned locally

Try to recursively cargo clean, there are some tests not belong to cargo's workspace and leftover build artifact can affect tests. Usually this error means test runner failed to build those internal projects.

@dsherret
Copy link
Contributor Author

dsherret commented Jun 5, 2023

@kwonoj thanks, I tried running cargo clean and cargo clean-recursive, but the error still persists.

@kdy1 kdy1 added this to the Planned milestone Jun 7, 2023
@kdy1
Copy link
Member

kdy1 commented Jun 7, 2023

I'll update test refs

@kdy1 kdy1 self-assigned this Jun 7, 2023
@kdy1 kdy1 changed the title fix(es/codegen): remove extra spaces in AssignPatProp and KeyValuePatProp fix(es/codegen): Remove extra spaces in AssignPatProp and KeyValuePatProp Jun 7, 2023
@kdy1 kdy1 enabled auto-merge (squash) June 7, 2023 03:12
@kdy1 kdy1 force-pushed the fix_codegen_pat_extraneous_spaces branch from 2204555 to bbbae86 Compare June 7, 2023 03:15
kdy1
kdy1 approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_codegen

swc-bot
swc-bot reviewed Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 064bcf4 into swc-project:main Jun 7, 2023
@kdy1 kdy1 modified the milestones: Planned, v1.3.63 Jun 12, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot

@kdy1 kdy1

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.63
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dsherret @kwonoj @kdy1 @swc-bot