feat(es/module): Preserve custom use directives
#7528
Merged
+113
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
changed the title
use directives
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
swc-bot
reviewed
Jun 15, 2023
magic-akari
reviewed
Jun 15, 2023
kdy1
added a commit
that referenced
this pull request
Jun 16, 2023
**Related issue:** - Closes #7315.
ammmze
reviewed
Jun 27, 2023
Comment on lines
147
to
149
| if self.config.strict_mode { | ||
| stmts.push(clone_first_use_strict(n).unwrap_or_else(use_strict)); | ||
| stmts.push(clone_first_use_directive(n).unwrap_or_else(use_strict)); | ||
| } |
There was a problem hiding this comment.
Maybe I'm not understanding what this is doing, but at first glance, does this mean that if an input file has a directive, it would only get hoisted to the top of the file if strictMode is enabled? I'm using strict mode, so it doesn't really affect me, but I imagine this would be a bug that may present itself in the future.
There was a problem hiding this comment.
I guess I must be mis-understanding. I just finished upgrading and tried it out setting strictMode to false and the directive still makes its way to the top. So you can ignore me...it is working as it should.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue: