Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(es/minifier): Drop unused properties #7534

Merged
merged 38 commits into from
Jul 4, 2023
Merged

feat(es/minifier): Drop unused properties #7534

merged 38 commits into from
Jul 4, 2023
+460 −262

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jun 16, 2023

@kdy1 kdy1 added this to the Planned milestone Jun 16, 2023
@kdy1 kdy1 self-assigned this Jun 16, 2023
kdy1
kdy1 commented Jun 21, 2023
View reviewed changes
crates/swc/tests/tsc-references/requireOfESWithPropertyAccess.2.minified.js Outdated
var x = {
grey: {}
};
var x = {};
export { x };
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bug

kdy1
kdy1 commented Jun 22, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_usage_analyzer

@kdy1 kdy1 marked this pull request as ready for review June 22, 2023 06:54
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 22, 2023
View reviewed changes
@kdy1 kdy1 requested a review from jridgewell June 22, 2023 06:54
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 22, 2023
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 22, 2023
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 22, 2023
View reviewed changes
@kdy1 kdy1 changed the title feat(es/minifier): Implement a rule for unused properties feat(es/minifier): Drop unused properties Jun 22, 2023
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 26, 2023
View reviewed changes
@kdy1 kdy1 marked this pull request as draft June 26, 2023 03:12
@kdy1 kdy1 marked this pull request as ready for review June 26, 2023 03:30
@kdy1 kdy1 enabled auto-merge (squash) July 4, 2023 04:21
swc-bot
swc-bot reviewed Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 47d2edd into swc-project:main Jul 4, 2023
@kdy1 kdy1 deleted the issue-7472 branch July 4, 2023 05:11
@kdy1 kdy1 modified the milestones: Planned, v1.3.68 Jul 5, 2023
@Austaras Austaras mentioned this pull request Jul 12, 2023
Closed
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot

@jridgewell jridgewell

@kodiakhq kodiakhq[bot]

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.68
Development

Successfully merging this pull request may close these issues.

SWC compress producing larger output than terser (minimal repro included)
3 participants
@kdy1 @jridgewell @swc-bot