Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/preset-env): Don't log Yield to the console #7548

Merged
merged 1 commit into from
Jun 20, 2023
Merged

fix(es/preset-env): Don't log Yield to the console #7548

merged 1 commit into from
Jun 20, 2023
+0 −1

Conversation

cjwilsontech
Copy link
Contributor

Description:

When a yield token is encountered by the parser, the word "Yield" is unnecessarily logged to the console. This PR removes the extra logging.

Related issue (if exists):

fix(preset-env): Don't log Yield to the console.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
9fc6a61
@CLAassistant
Copy link

CLAassistant commented Jun 20, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kdy1 kdy1 added this to the Planned milestone Jun 20, 2023
@kdy1 kdy1 changed the title fix(preset-env): Don't log Yield to the console. fix(es/preset-env): Don't log Yield to the console Jun 20, 2023
@kdy1 kdy1 enabled auto-merge (squash) June 20, 2023 01:51
kdy1
kdy1 approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_ecma_preset_env

@kdy1 kdy1 merged commit 8cfc4f9 into swc-project:main Jun 20, 2023
@kdy1 kdy1 modified the milestones: Planned, v1.3.66 Jun 20, 2023
@cjwilsontech cjwilsontech deleted the remove-println-yield branch June 20, 2023 18:40
@swc-project swc-project locked as resolved and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.66
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cjwilsontech @CLAassistant @kdy1