Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(estree/compat): Adjust loc.col #7565

Merged
merged 3 commits into from Jun 22, 2023
Merged

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Jun 22, 2023

Description:

Minor update to compat translation to the loc to match with what acorn does.

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_estree_compat

@kdy1 kdy1 added this to the Planned milestone Jun 22, 2023
@kdy1 kdy1 changed the title fix(estree_compat): adjust loc_col fix(estree/compat): Adjust loc.col Jun 22, 2023
@kdy1 kdy1 enabled auto-merge (squash) June 22, 2023 07:53
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kwonoj
Copy link
Member Author

kwonoj commented Jun 22, 2023

Testing for bindings are failing with version conflict? 🤔

Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit d86f8f6 into swc-project:main Jun 22, 2023
127 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.67 Jun 29, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants