refactor(common): Remove add_bitflags and update bitflags

[kosayoda]

The add_flags macro makes impl blocks for the bitflags struct separately from the one generated by bitflags. This is incorrect because the bitflags implementation uses the listed constants to generate certain method bodies.

I opted to manually specify the bitflags macro instead of modifying the add_flags macro to remove complexity (the bitflags structs are not changed often).

The PR also bumps the version of bitflags to 2.3.2 to ensure that the added tests #7542, #7545 still pass.

Fixes: #7513
Related: bitflags/bitflags#365

Details

In the linked issue, commas were not added in the minified codegen because this line:

swc/crates/swc_ecma_codegen/src/lib.rs

Lines 1944 to 1948 in 068c172

	if !emit_new_line {
	list_format -= ListFormat::MultiLine | ListFormat::Indented;
	}

Causes list_format to be set to the empty ListFormat due to the SubAssign implementation.

• Bitflags 2.2.x
  The implementation is like this:

   ListFormat SubAssign -> InternalBitFlags difference() -> u32 BitAnd + u32 Not
  
• Bitflags 2.3.x
  The implementation is like this:

   ListFormat SubAssign -> InternalBitFlags BitAnd -> u32 BitAnd
                        -> InternalBitFlags BitNot -> InternalBitFlags complement() -> InternalBitFlags from_bits_truncate() + u32 Not
  

The key is the change to use from_bits_truncate. This code:

bitflags::bitflags! {
    #[derive(Clone, Copy)]
    struct Flags: u32 {
        const A = 0b00000001;
        const B = 0b00000010;
        const C = 0b00000100;
    }
}

generates this output:

#[inline]
pub const fn from_bits_truncate(bits: u32) -> Self {
    let bits = bits;
    {
        if bits == <u32 as ::bitflags::Bits>::EMPTY {
            return Self(bits);
        }
        let mut truncated = <u32 as ::bitflags::Bits>::EMPTY;
        // IMPORTANT!
        {
            if bits & Flags::A.bits() == Flags::A.bits() {
                truncated = truncated | Flags::A.bits();
            }
        };
        {
            if bits & Flags::B.bits() == Flags::B.bits() {
                truncated = truncated | Flags::B.bits();
            }
        };
        {
            if bits & Flags::C.bits() == Flags::C.bits() {
                truncated = truncated | Flags::C.bits();
            }
        };
        // IMPORTANT!
        Self(truncated)
    }
}

Using the add_bitflags! macro in swc_common, the flags are manually added to the struct after bitflags code generation, so the middle parts are not generated, eventually causing SubAssign to return an empty flag struct.

[CLAassistant]

All committers have signed the CLA.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[kdy1]

Thank you!

---

swc-bump:

• swc_common

[Swatinem]

FYI: this should have been a semver-breaking release for swc_common, as it is removing add_bitflags which was used by some older versions of dependent swc crates.

I believe this broke us downstream. No big deal, bumping to the very latest versions of the swc crates was long overdue: getsentry/js-source-scopes#22

[kdy1]

I know, but I decided I don't care.