Skip to content

feat(es/minifier): Inline constants even if they are exported #7583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 27, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jun 26, 2023

Description:

Related issue:

@kdy1 kdy1 added this to the Planned milestone Jun 26, 2023
@kdy1 kdy1 self-assigned this Jun 26, 2023
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_usage_analyzer

@kdy1 kdy1 requested a review from jridgewell June 26, 2023 04:30
@kdy1 kdy1 marked this pull request as ready for review June 26, 2023 04:30
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 26, 2023
@valkum
Copy link

valkum commented Jun 26, 2023

Thanks for the quick fix. I checked this against a slightly larger example and it works.

@kdy1 kdy1 enabled auto-merge (squash) June 27, 2023 00:53
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 398e922 into swc-project:main Jun 27, 2023
@kdy1 kdy1 deleted the issue-7575 branch June 27, 2023 02:14
@kdy1 kdy1 modified the milestones: Planned, v1.3.67 Jun 29, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

export const breaks toplevel analysis
4 participants