Skip to content

fix(es/fixer): Don't change default decls to default expr exports #7585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 29, 2023
Merged

fix(es/fixer): Don't change default decls to default expr exports #7585

merged 4 commits into from
Jun 29, 2023
+33 −0

Conversation

underfin
Copy link
Contributor

@underfin underfin commented Jun 26, 2023 •
edited by kdy1
Loading

@underfin underfin force-pushed the fix-export-default-paren-expr-fixer branch from 0a9a629 to 5c441a0 Compare June 29, 2023 03:13
kdy1
kdy1 requested changes Jun 29, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

swc-bump:

  • swc_ecma_transforms_base

@kdy1 kdy1 added this to the Planned milestone Jun 29, 2023
@kdy1 kdy1 changed the title fix: the simplify + fixer transform shouldn't remove paren expr at ex… fix(es/fixer): Don't make default decls into default expr exports Jun 29, 2023
@kdy1 kdy1 changed the title fix(es/fixer): Don't make default decls into default expr exports fix(es/fixer): Don't change default decls into default expr exports Jun 29, 2023
@kdy1 kdy1 changed the title fix(es/fixer): Don't change default decls into default expr exports fix(es/fixer): Don't change default decls to default expr exports Jun 29, 2023
@underfin underfin force-pushed the fix-export-default-paren-expr-fixer branch from 332da6c to 30c1fae Compare June 29, 2023 06:42
kdy1
kdy1 approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kdy1 kdy1 enabled auto-merge (squash) June 29, 2023 07:01
@underfin
Copy link
Contributor Author

underfin commented Jun 29, 2023 •
edited
Loading

@kdy1 I don't know how update all snapshot with test, can you point me out? Thanks !

@kdy1
Copy link
Member

kdy1 commented Jun 29, 2023

UPDATE=1 cargo test will do it, but it does not modify rust files.

@underfin
Copy link
Contributor Author

Thanks! I'm so sad because i want to update the snapshot at rust files test ...

@kdy1 kdy1 merged commit e272545 into swc-project:main Jun 29, 2023
@underfin underfin deleted the fix-export-default-paren-expr-fixer branch June 29, 2023 08:17
@kdy1 kdy1 modified the milestones: Planned, v1.3.68 Jul 5, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@magic-akari magic-akari

@kdy1 kdy1

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.68
Development

Successfully merging this pull request may close these issues.

SimplifyExpr & Fixer should skip ParenExpr at ExportDefaultExpr
3 participants
@underfin @kdy1 @magic-akari