feat(es/minifier): Common sub expression in seq in condition #7587
+180
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
reviewed
Jun 27, 2023
Austaras
force-pushed
the
main
branch
2 times, most recently
from
4ded4fb to
fa8f5a9
Compare
kdy1
requested changes
Jun 29, 2023
kdy1
approved these changes
Jul 3, 2023
jridgewell
approved these changes
Jul 4, 2023
Comment on lines
+627
to
+632
| && left.exprs[left_len - idx - 1] | ||
| .eq_ignore_span(&right.exprs[right_len - idx - 1]) | ||
| && !matches!( | ||
| &*left.exprs[left_len - idx - 1], | ||
| Expr::Yield(..) | Expr::Fn(..) | ||
| ) |
There was a problem hiding this comment.
Nit: we could trim both the start and the end of the sequences.
swc-bot
reviewed
Jul 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
BREAKING CHANGE:
Related issue (if exists):