fix(plugin/runner): Disable wasi env cleanup #7607
Merged
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
approved these changes
Jun 30, 2023
kdy1
changed the title
swc-bot
reviewed
Jun 30, 2023
swc-bot
reviewed
Jun 30, 2023
lsdyi
pushed a commit
to lsdyi/swc
that referenced
this pull request
Jul 3, 2023
**Description:** Even after setting shared runtime for the wasi env, `cleanup` still panics. I suspect something internal to cleanup doesn't honor those handles correctly; for now, disable it and try to see if this works. As commented, this is not a huge issue as the plugin usually doesn't have resources to be cleaned up anyway.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Even after setting shared runtime for the wasi env,
cleanupstill panics. I suspect something internal to cleanup doesn't honor those handle correctly, for now disable and try to see if this works.As commented, this is not a huge issue as plugin in most cases doesn't have resources to be cleaned up anyway.