refactor(es/minifier): Respect toplevel and module options
#7671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Austaras
commented
Jul 18, 2023
| @@ -15415,27 +15415,27 @@ | |||
| } | |||
| ]); | |||
| for(var i = 0; i < lastLevelTicks.length - 1; i++){ | |||
| var approxInterval1, approxInterval2, approxInterval3, startTick = lastLevelTicks[i].value, endTick = lastLevelTicks[i + 1].value; | |||
| var approxInterval1, startTick = lastLevelTicks[i].value, endTick = lastLevelTicks[i + 1].value; | |||
Austaras
commented
Jul 18, 2023
| }(), function(exports) { | ||
| exports.default = void 0, exports.default = String; | ||
| }(), (void 0).__esModule = !0, (void 0).__esModule = !0, (void 0).__esModule = !0; | ||
| }(), exports.default = null, (void 0).exports = exports.default, (void 0).default = void 0, exports1.default = void 0, (void 0).exports = exports1.default, exports2.default = void 0, (void 0).exports = exports2.default, exports3.default = void 0, exports3.default = String, exports4.default = void 0, exports4.default = String, (void 0).__esModule = !0, (void 0).__esModule = !0, (void 0).__esModule = !0; |
Austaras
commented
Jul 18, 2023
| @@ -12,6 +12,7 @@ export var modifiers = { | |||
| 0 | |||
| ]; | |||
| else { | |||
| var offset1, popperOffsets, referenceOffsets; | |||
There was a problem hiding this comment.
This test case doesn't enable unused or side_effect.
Austaras
commented
Jul 18, 2023
| console.log((o.a = 3, { | ||
| x: o.a, | ||
| y: o.b | ||
| })); |
There was a problem hiding this comment.
sequences take effect without being configured.
Austaras
commented
Jul 18, 2023
| }, { | ||
| x: c.a, | ||
| y: c.b | ||
| })); |
Austaras
commented
Jul 18, 2023
| b: 2 | ||
| }).a, | ||
| y: o.b | ||
| }); |
There was a problem hiding this comment.
terser cannot handle duplicate idents.
Austaras
commented
Jul 18, 2023
| @@ -1,3 +1,3 @@ | |||
| var unused; | |||
| const CONST_FOO = !1; | |||
| var moo, bar; | |||
| var moo; | |||
Austaras
commented
Jul 18, 2023
| }; | ||
| var f0 = ()=>0; | ||
| var f1 = ()=>{}; | ||
| var f2 = ()=>{}; |
There was a problem hiding this comment.
unused pass is enabled when side_effects set to true in swc.
Austaras
commented
Jul 18, 2023
| for(var k in "12"){ | ||
| var b = void 0; | ||
| void ((b >>= 1) && (a = "FAIL"), b = 2); | ||
| } |
Austaras
commented
Jul 18, 2023
...ma_minifier/tests/terser/compress/identity/inline_identity_dont_lose_this_when_arg/output.js
Show resolved
Hide resolved
Austaras
commented
Jul 18, 2023
crates/swc_ecma_minifier/tests/terser/compress/identity/inline_identity_lose_this/output.js
Show resolved
Hide resolved
Austaras
commented
Jul 18, 2023
| , y = 3; | ||
| console.log(2, y, 4, 2 * y, 8, 4 * y, 2, g(), 4); | ||
| const g = ()=>y, y = 3; | ||
| console.log(2, y, 4, 2 * y, 8, 4 * y, 2, y, 4); |
jridgewell
previously approved these changes
Jul 18, 2023
kdy1
changed the title
TopLevel and Moduletoplevel and Module
kdy1
changed the title
toplevel and Moduletoplevel and module options
kdy1
changed the title
toplevel and module optionstoplevel and module options
kdy1
previously approved these changes
Jul 19, 2023
|
Yeah, TSC tests need update. It would be one thousand lines of update, mostly removing top level use strict. |
|
It's weird. I cannot reproduce the CI failure, seems like it's comparing to pre updated tests. |
|
I'll update them by myself. Thank you again for the work! |
|
I'll fix CI with another PR because I'm not sure about the way to reproduce test failure locally |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
BREAKING CHANGE:
Related issue (if exists):