Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(css/parser): Support @starting-style #7677

Merged
merged 3 commits into from Jul 20, 2023
Merged

feat(css/parser): Support @starting-style #7677

merged 3 commits into from Jul 20, 2023

Conversation

CGQAQ
Copy link
Contributor

@CGQAQ CGQAQ commented Jul 19, 2023

This at rule allow authors to start CSS transitions on first style update. That is, you can now make the transition take effect when the display property changes from none to block.

Based on evanw/esbuild#3249

kdy1
kdy1 approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_atoms

@kdy1 kdy1 added this to the Planned milestone Jul 20, 2023
@kdy1 kdy1 changed the title feat: @starting-style feat(css/parser): Support @starting-style Jul 20, 2023
@kdy1 kdy1 enabled auto-merge (squash) July 20, 2023 02:37
swc-bot
swc-bot reviewed Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 disabled auto-merge July 20, 2023 05:55
@kdy1 kdy1 merged commit cfb7b51 into swc-project:main Jul 20, 2023
247 of 249 checks passed
@CGQAQ CGQAQ deleted the at-rule-starting-style branch July 20, 2023 08:22
@kdy1 kdy1 modified the milestones: Planned, v1.3.71 Jul 25, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yisibl yisibl yisibl left review comments

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.71
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CGQAQ @yisibl @kdy1 @swc-bot