Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/minifier): Handle synthesized export default expression #7707

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

Austaras
Copy link
Member

Description:
Fixes #7634. There's no need to avoid import idents in non top level scope.

BREAKING CHANGE:

Related issue (if exists):

@kdy1 kdy1 requested a review from jridgewell July 27, 2023 01:43
@kdy1 kdy1 self-assigned this Jul 27, 2023
@kdy1 kdy1 added this to the Planned milestone Jul 27, 2023
@kdy1 kdy1 self-requested a review July 28, 2023 04:53
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! What a smart solution 👍!


swc-bump:

  • swc_ecma_transforms_base

@kdy1 kdy1 changed the title fix(es): Handle synthesized export default expression fix(es/minifier): Handle synthesized export default expression Jul 31, 2023
@kdy1 kdy1 enabled auto-merge (squash) July 31, 2023 03:14
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 5ea6f27 into swc-project:main Jul 31, 2023
@kdy1 kdy1 modified the milestones: Planned, v1.3.73 Aug 1, 2023
kdy1 pushed a commit to kdy1/swc that referenced this pull request Aug 15, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Mangling sometimes reuses and attempts to re-declare symbols used in imports
4 participants