Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/module): Do not determine module name for modules without exports in UMD #7718

Merged
merged 3 commits into from Jul 28, 2023
Merged

fix(es/module): Do not determine module name for modules without exports in UMD #7718

merged 3 commits into from Jul 28, 2023

Conversation

magic-akari
Copy link
Member

@magic-akari magic-akari commented Jul 27, 2023 •
edited by kdy1

Description:

Related issue:

@magic-akari magic-akari marked this pull request as ready for review July 27, 2023 10:14
@kdy1 kdy1 self-assigned this Jul 28, 2023
kdy1
kdy1 approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_ecma_transforms_module

@kdy1 kdy1 enabled auto-merge (squash) July 28, 2023 03:34
@kdy1 kdy1 disabled auto-merge July 28, 2023 03:34
@kdy1 kdy1 changed the title fix(es/module): Do not determine filename if no exports fix(es/module): Do not determine module name for modules without exports in UMD Jul 28, 2023
@kdy1 kdy1 added this to the Planned milestone Jul 28, 2023
@kdy1 kdy1 enabled auto-merge (squash) July 28, 2023 03:34
swc-bot
swc-bot reviewed Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 40136f7 into swc-project:main Jul 28, 2023
249 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.72 Jul 28, 2023
kdy1 pushed a commit to kdy1/swc that referenced this pull request Aug 15, 2023
@magic-akari @kdy1
fix(es/module): Do not determine module name for modules without expo…
2998ed9 
…rts in UMD (swc-project#7718)

**Related issue:**

 - Closes swc-project#6263.
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 28, 2023
@magic-akari magic-akari deleted the fix/issue-6263 branch September 18, 2023 08:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.72
Development

Successfully merging this pull request may close these issues.

module umd not working on m1 mac
3 participants
@magic-akari @kdy1 @swc-bot