Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es): Fix typo in a warning #7740

Merged
merged 2 commits into from Aug 2, 2023
Merged

fix(es): Fix typo in a warning #7740

merged 2 commits into from Aug 2, 2023

Conversation

BiscuiTech
Copy link
Contributor

@BiscuiTech BiscuiTech commented Aug 2, 2023 •
edited

Description:

With the recent versions, there's a new error that tells us that jsc.env should not be used with jsc.target. But jsc.env does not exist. It's a typo with env at the root of the config.

BREAKING CHANGE:

No breaking changes.

Related issue (if exists):
No linked issue.

@BiscuiTech BiscuiTech changed the title fix: warning should be about target, not jsc.target fix: warning should be about env, not jsc.env Aug 2, 2023
@kdy1 kdy1 changed the title fix: warning should be about env, not jsc.env fix(es): Fix typo in a warning Aug 2, 2023
@kdy1 kdy1 self-assigned this Aug 2, 2023
@kdy1 kdy1 added this to the Planned milestone Aug 2, 2023
@kdy1 kdy1 enabled auto-merge (squash) August 2, 2023 20:09
kdy1
kdy1 approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

swc-bump:

  • swc

@kdy1 kdy1 merged commit 22e06cc into swc-project:main Aug 2, 2023
127 checks passed
@BiscuiTech BiscuiTech deleted the fix/jsc.target-mixup branch August 2, 2023 20:42
@kdy1 kdy1 modified the milestones: Planned, v1.3.74 Aug 2, 2023
kdy1 pushed a commit to kdy1/swc that referenced this pull request Aug 15, 2023
@BiscuiTech @kdy1
fix(es): Fix typo in a warning (swc-project#7740)
5894c4f
@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

@KthulupwnsAsura KthulupwnsAsura KthulupwnsAsura approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.74
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BiscuiTech @kdy1 @KthulupwnsAsura