Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/compat): Remove wrong logic for object patterns in object_rest #7788

Merged
merged 30 commits into from
Aug 17, 2023
Merged

fix(es/compat): Remove wrong logic for object patterns in object_rest #7788

merged 30 commits into from
Aug 17, 2023
+1,349 −1,249

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Aug 9, 2023

@kdy1 kdy1 added this to the Planned milestone Aug 9, 2023
@kdy1 kdy1 self-assigned this Aug 9, 2023
@kdy1 kdy1 changed the title fix(es/compat): Fix destructuring fix(es/compat): Remove wrong logic for object patterns in object_rest Aug 17, 2023
kdy1
kdy1 commented Aug 17, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_compat

kdy1
kdy1 commented Aug 17, 2023
View reviewed changes
crates/swc_ecma_transforms_compat/tests/es2018_object_rest_spread.rs Outdated
function a5(_param) {
var { a3, b2: { ba1 } } = _param, ba2 = _object_without_properties(_param.b2, [
"ba1"
]), c3 = _object_without_properties(_param, [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a regression

@kdy1 kdy1 marked this pull request as ready for review August 17, 2023 03:29
@kdy1 kdy1 enabled auto-merge (squash) August 17, 2023 03:29
swc-bot
swc-bot reviewed Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 3766a7c into swc-project:main Aug 17, 2023
@kdy1 kdy1 deleted the issue-7776 branch August 17, 2023 04:01
@kdy1 kdy1 modified the milestones: Planned, v1.3.78 Aug 17, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot

@kodiakhq kodiakhq[bot]

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.78
Development

Successfully merging this pull request may close these issues.

Destructuring function array arg with 2 object destructuring entries causes clashing variable names
2 participants
@kdy1 @swc-bot