refactor(common): Make ahash
optional
#7816
Merged
+13
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This adds the ability to not include
ahash
with swc_common, which caused some issues for me compiling dprint-plugin-typescript to Wasm because of:(I can't enable the JS feature because it's running the wasm file in Wasmer and also I don't support Wasi in dprint plugins)
BREAKING CHANGE:
This removes swc_common's "perf" feature and makes it the default, then adds an
ahash
feature instead. An alternative would be to make theahash
dep optional and part of the default features, then dodefault-features = false
in the downstream crates (I think, but I'm not sure), but I figure most people will be using the perf default anyway? I'm not sure what's preferable.Related issue: