Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(css/ast): Support @scope at-rule #7837

Merged
merged 11 commits into from Aug 24, 2023
Merged

feat(css/ast): Support @scope at-rule #7837

merged 11 commits into from Aug 24, 2023

Conversation

CGQAQ
Copy link
Contributor

@CGQAQ CGQAQ commented Aug 18, 2023 •
edited

Describe the feature

Chrome 118 is shipping soon, which is expected to be one of the more popular CSS features, giving new hope for style isolation of components.

Closed: #7836

@CGQAQ CGQAQ marked this pull request as ready for review August 18, 2023 14:52
@CGQAQ CGQAQ changed the title feat: @scope, not tested yet feat: @scope Aug 18, 2023
kdy1
kdy1 approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_atoms
  • swc_css_ast --breaking

@kdy1 kdy1 changed the title feat: @scope feat(css/ast): Support @scope at-rule Aug 24, 2023
@kdy1 kdy1 enabled auto-merge (squash) August 24, 2023 07:32
swc-bot
swc-bot reviewed Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit a34f359 into swc-project:main Aug 24, 2023
251 checks passed
@yisibl yisibl deleted the at-scope branch August 24, 2023 08:26
@kdy1 kdy1 modified the milestones: Planned, v1.3.79 Sep 13, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.79
Development

Successfully merging this pull request may close these issues.

Support CSS @scope rule
3 participants
@CGQAQ @kdy1 @swc-bot