-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(es/codegen): Fix placing of comments of yield arguments #7858
fix(es/codegen): Fix placing of comments of yield arguments #7858
Conversation
We may need swc/crates/swc_ecma_codegen/src/lib.rs Lines 2936 to 2940 in 5ae2e81
emit_yield_expr too.
swc/crates/swc_ecma_codegen/src/lib.rs Lines 1882 to 1886 in 5ae2e81
|
4630e76
to
7d1bc9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
swc-bump:
- swc_ecma_codegen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated review comment generated by auto-rebase script
**Description:** x-ref: https://vercel.slack.com/archives/C02HY34AKME/p1695334071194139 Reproduction: https://github.com/kdy1/repro-test-mdx-korean Regression of next.js: `v13.4.11`(swc_core@v0.79.13) => `v13.5.2` (swc_core@v0.83.12) - `next@v13.4.19` works (swc_core@v0.79.59) - `next@v13.4.20-canary.3` works (swc_core@v0.79.70) - **`next@v13.4.20-canary.32` fails** (swc_core@v0.83.12) Commit range: 662f236...e67bf05 - `swc_core@v0.79.70`: 662f236 - `swc_core@v0.83.12`: e67bf05 Diff: https://gist.github.com/kdy1/047e7e5537c34180d446cb3d5b95fce8 --- I did more investigation by monkey-patching the `next` package. `.minify()` resolved without an exception. It means that `.minify()` is producing an invalid ES code. So... candidates are - #7890 - #7876 - #7858 - #7856 - #7853 - #7832
Description:
Looks like the bug I ran into had nothing to do with the changes in #7856, since it's reproducible without it. Looks like it might have only surfaced now because #7853 changed the default value of
jsc.minify.format.comments
? Added a minimal test case here with the expected result.Here's the actual output:
The comment ends up getting added after the yield, which makes the output invalid.
Going to see if I can figure out a fix tomorrow, but let me know if you have any ideas on where to start looking in the meantime!