Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/compat): Handle single expression case in static block #7944

Merged
merged 5 commits into from Sep 14, 2023
Merged

fix(es/compat): Handle single expression case in static block #7944

merged 5 commits into from Sep 14, 2023

Conversation

magic-akari
Copy link
Member

@magic-akari magic-akari commented Sep 13, 2023 •
edited by kdy1

kdy1
kdy1 previously approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_compat

@kdy1 kdy1 self-assigned this Sep 13, 2023
@kdy1 kdy1 added this to the Planned milestone Sep 13, 2023
@kdy1 kdy1 enabled auto-merge (squash) September 13, 2023 03:39
@kdy1 kdy1 disabled auto-merge September 13, 2023 03:40
@kdy1
Copy link
Member

kdy1 commented Sep 13, 2023

CI failed

@magic-akari
Copy link
Member Author

CI failed

Test cases updated.

kdy1
kdy1 approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_compat

@kdy1 kdy1 enabled auto-merge (squash) September 14, 2023 02:02
swc-bot
swc-bot reviewed Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit a80aec4 into swc-project:main Sep 14, 2023
251 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.85 Sep 15, 2023
@magic-akari magic-akari deleted the fix/issue-7922 branch September 18, 2023 08:42
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.85
Development

Successfully merging this pull request may close these issues.

Avoid IIFEs for static class member definition with useDefineForClassFields: false
3 participants
@magic-akari @kdy1 @swc-bot