Skip to content

feat(es/module): Add an option to make resolver fully resolve index.js #7945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 14, 2023
Merged

feat(es/module): Add an option to make resolver fully resolve index.js #7945

merged 12 commits into from
Sep 14, 2023
+266 −160

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Sep 13, 2023 •
edited
Loading

Description:

  • jsc.module.resolveFully is added to support resolving as .js.

Related issue:

@kdy1 kdy1 added this to the Planned milestone Sep 13, 2023
@kdy1 kdy1 self-assigned this Sep 13, 2023
kdy1
kdy1 commented Sep 14, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_module

@kdy1 kdy1 marked this pull request as ready for review September 14, 2023 06:40
@kdy1 kdy1 enabled auto-merge (squash) September 14, 2023 06:40
@swc-bot
Merge branch 'main' into jsc-paths-opt

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
e01467a
swc-bot
swc-bot reviewed Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 7e8d72d into swc-project:main Sep 14, 2023
@kdy1 kdy1 deleted the jsc-paths-opt branch September 14, 2023 07:17
@kdy1 kdy1 modified the milestones: Planned, v1.3.85 Sep 15, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot

@kodiakhq kodiakhq[bot]

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.85
Development

Successfully merging this pull request may close these issues.

ERR_UNSUPPORTED_DIR_IMPORT Option to make jsc.paths fully specify /index.js (and/or extension)
2 participants
@kdy1 @swc-bot