Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Do not inline into a template literal with sequential inliner #7971

Merged
merged 11 commits into from
Sep 20, 2023
Merged

fix(es/minifier): Do not inline into a template literal with sequential inliner #7971

merged 11 commits into from
Sep 20, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Sep 19, 2023

@kdy1 kdy1 added this to the Planned milestone Sep 19, 2023
@kdy1 kdy1 self-assigned this Sep 19, 2023
kdy1
kdy1 commented Sep 19, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

@kdy1 kdy1 changed the title fix(es/minifier): Fix a bug of the minifier fix(es/minifier): Do not inline into a template literal with sequential inliner Sep 19, 2023
@kdy1 kdy1 marked this pull request as ready for review September 19, 2023 02:24
kodiakhq[bot]
kodiakhq bot previously approved these changes Sep 19, 2023
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes Sep 19, 2023
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) September 19, 2023 06:51
swc-bot
swc-bot reviewed Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

kdy1
kdy1 commented Sep 20, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reset ci

@kdy1 kdy1 merged commit b3d3a7b into swc-project:main Sep 20, 2023
250 checks passed
@kdy1 kdy1 deleted the issue-7969 branch September 20, 2023 06:57
@kdy1 kdy1 modified the milestones: Planned, v1.3.87 Sep 22, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@jridgewell jridgewell jridgewell approved these changes

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.87
Development

Successfully merging this pull request may close these issues.

Minifier produces incorrect code when template literals are used
3 participants
@kdy1 @jridgewell @swc-bot