fix(es/codegen): Fix codegen of unicode surrogates #7985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
force-pushed
the
next-swc-regression-minify
branch
3 times, most recently
from
87a96e5
to
c23a481
Compare
kdy1
force-pushed
the
next-swc-regression-minify
branch
2 times, most recently
from
e51bc28
to
0d513c9
Compare
kdy1
changed the title
|
Investigation: This was not a regression. This is simply a bug. I'll take some rest and fix it. |
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
kdy1
changed the title
0xffff
swc-bot
reviewed
Sep 25, 2023
swc-bot
reviewed
Sep 25, 2023
kdy1
changed the title
0xffff
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
x-ref: https://vercel.slack.com/archives/C02HY34AKME/p1695334071194139
Reproduction: https://github.com/kdy1/repro-test-mdx-korean
Regression of next.js:
v13.4.11(swc_core@v0.79.13) =>v13.5.2(swc_core@v0.83.12)next@v13.4.19works (swc_core@v0.79.59)next@v13.4.20-canary.3works (swc_core@v0.79.70)next@v13.4.20-canary.32fails (swc_core@v0.83.12)Commit range: 662f236...e67bf05
swc_core@v0.79.70: 662f236swc_core@v0.83.12: e67bf05Diff: https://gist.github.com/kdy1/047e7e5537c34180d446cb3d5b95fce8
I did more investigation by monkey-patching the
nextpackage..minify()resolved without an exception.It means that
.minify()is producing an invalid ES code.So... candidates are
mutatedandmutation_by_call_count#7890is_fn_localeven if var is hoisted #7876jsc.minify.format.comments#7853reassigned#7832Related issue (if exists):