Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/compat): Use return statements for method and setter decorator #8017

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

jrandolf
Copy link
Contributor

@jrandolf jrandolf commented Sep 27, 2023

Description:
This aligns with other implementations such as TypeScript's and correctly implements the currently proposed behavior.

Related issue:

@CLAassistant
Copy link

CLAassistant commented Sep 27, 2023

CLA assistant check
All committers have signed the CLA.

This aligns with other implementations such as TypeScript's and correctly implements the currently proposed behavior.

Fixed: #8015
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need a new version of @swc/core?


swc-bump:

  • swc_ecma_transforms_proposal

@kdy1 kdy1 changed the title fix(es/compat): use return statements for method and setter decorator fix(es/compat): Use return statements for method and setter decorator Sep 27, 2023
@kdy1 kdy1 enabled auto-merge (squash) September 27, 2023 23:27
@kdy1 kdy1 added this to the Planned milestone Sep 27, 2023
@kdy1 kdy1 merged commit 38bc710 into swc-project:main Sep 27, 2023
129 checks passed
@jrandolf jrandolf deleted the jrandolf/fix-decorators branch September 28, 2023 13:07
@kdy1 kdy1 modified the milestones: Planned, v1.3.91 Oct 1, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Private decorator implementation is incorrect.
3 participants