fix(es/typescript): Rename wrong unresolved_mark
#8018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
magic-akari
commented
Sep 27, 2023
| @@ -1101,7 +1101,7 @@ impl Transform { | |||
| expr.make_assign_to( | |||
| op!("="), | |||
| member_expr!( | |||
| DUMMY_SP.apply_mark(self.unresolved_mark), | |||
| DUMMY_SP.apply_mark(self.top_level_mark), | |||
| module.exports | |||
There was a problem hiding this comment.
It does look like unresolved_mark needs to be used here instead of top_level_mark, I'll confirm that later.
There was a problem hiding this comment.
However, TsImportExportAssignConfig::Classic is not used in any part of the code, so it may be unnecessary to handle it here.
kdy1
approved these changes
Sep 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is just a typo fix. No functional changes are expected.
However, correcting the wrong parameter name will avoid confusing our Rust-side users.
BREAKING CHANGE:
Related issue (if exists):
Import declarations in a namespace cannot reference a module? #8016