fix(es/compat): Generate OptCall for OptCall for private fields
#8031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Austaras
commented
Sep 29, 2023
| @@ -400,7 +398,11 @@ impl VisitMut for Fixer<'_> { | |||
| fn visit_mut_call_expr(&mut self, node: &mut CallExpr) { | |||
| let old = self.visit_call(&mut node.args, &mut node.callee); | |||
| if let Callee::Expr(e) = &mut node.callee { | |||
| self.wrap_callee(e) | |||
| if let Expr::OptChain(_) = &**e { | |||
| self.wrap(e) | |||
There was a problem hiding this comment.
This is unnecessary -- swc parser and paren_remover won't generate such structure, but it's better to be safe.
Austaras
force-pushed
the
main
branch
2 times, most recently
from
d2fbdc0
to
cd65db4
Compare
kdy1
changed the title
OptCall for OptCall for private fields
kdy1
approved these changes
Sep 29, 2023
swc-bot
reviewed
Sep 29, 2023
swc-bot
reviewed
Sep 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: