Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): Make CLI testable/managable with swc-bump #8045

Merged
merged 20 commits into from
Oct 2, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 2, 2023

Description:

It was hard to maintain CLI because actual logic was in ./bindings.

@kdy1 kdy1 added this to the Planned milestone Oct 2, 2023
@kdy1 kdy1 self-assigned this Oct 2, 2023
@kdy1 kdy1 marked this pull request as ready for review October 2, 2023 12:45
@kdy1 kdy1 enabled auto-merge (squash) October 2, 2023 12:45
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 2, 2023
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_cli_impl

@kdy1 kdy1 merged commit f717cf2 into swc-project:main Oct 2, 2023
131 checks passed
@kdy1 kdy1 deleted the cli branch October 2, 2023 15:46
@kdy1 kdy1 modified the milestones: Planned, v1.3.92 Oct 5, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant