Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/compat): Transform default-exported class decorators correctly #8050

Merged
merged 3 commits into from
Oct 2, 2023
Merged

fix(es/compat): Transform default-exported class decorators correctly #8050

merged 3 commits into from
Oct 2, 2023

Conversation

alekitto
Copy link
Contributor

@alekitto alekitto commented Oct 2, 2023 •
edited by kdy1

Description:

Process decorators on the class expression on export default declaration and ensure to execute tests for the feature.

Related issue:

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@kdy1 kdy1 added this to the Planned milestone Oct 2, 2023
kdy1
kdy1 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_proposal

@kdy1 kdy1 changed the title fix(es/compat): transform default-exported class decorators correctly fix(es/compat): Transform default-exported class decorators correctly Oct 2, 2023
@kdy1 kdy1 enabled auto-merge (squash) October 2, 2023 15:25
swc-bot
swc-bot reviewed Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit a751f1c into swc-project:main Oct 2, 2023
257 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.92 Oct 5, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.92
Development

Successfully merging this pull request may close these issues.

Default exported class with decorators are not transformed correctly
4 participants
@alekitto @CLAassistant @kdy1 @swc-bot