fix(es/codegen): Fix codegen of type-only imports #8070
Merged
+64
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type-only imports like:
```ts
import type { A } from 'b';
import { type C } from 'd';
```
currently fail to emit correctly. This means that if you're using swc to apply transformations to TS that *don't* include stripping the types, you accidentally change the semantics of these import statements.
This PR adds tests for these cases and fixes the emitters.
|
|
|
|
kdy1
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type-only imports like:
currently emit as regular imports:
This means that if you're using swc to apply transformations to TS that don't include the typescript-to-js transform, you accidentally change the semantics of these import statements.
This PR adds tests for these cases and fixes the emitters.