Skip to content

fix(es/utils): Skip var declarator name in RefRewriter #8125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2023
Merged

fix(es/utils): Skip var declarator name in RefRewriter #8125

merged 2 commits into from
Oct 15, 2023
+24 −0

Conversation

magic-akari
Copy link
Member

@magic-akari magic-akari commented Oct 15, 2023 •
edited by kdy1
Loading

@kdy1 kdy1 self-assigned this Oct 15, 2023
@kdy1 kdy1 added this to the Planned milestone Oct 15, 2023
@magic-akari magic-akari marked this pull request as ready for review October 15, 2023 06:55
kdy1
kdy1 approved these changes Oct 15, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

swc-bump:

  • swc_ecma_utils

@kdy1 kdy1 enabled auto-merge (squash) October 15, 2023 09:50
swc-bot
swc-bot reviewed Oct 15, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit fb81a36 into swc-project:main Oct 15, 2023
@magic-akari magic-akari deleted the fix/issue-8124 branch October 15, 2023 14:12
@kdy1
Copy link
Member

kdy1 commented Oct 19, 2023

cc @magic-akari This caused a regression of common js transform.

Wrong: https://play.swc.rs/?version=1.3.94-nightly-20231016.1&code=H4sIAAAAAAAAA%2B0ca5PTOPJ7foWOosqZq8SZmWX37rI7wPDePQ5YZtj7QFHg2EqiHccyfsyQC%2Fnv1y3Jr1iynUxggUI1VZPIaqnf6m5LYYuQRwlZkceRE85%2Ff3rfZzRIyJpMI74g1gx73%2FvDiL5PaZxYPSbH%2F3mVPKAu96gaB9%2BHnuiwetmYZBlSmPhVTKN8PtsewV%2FouBfOjMbwYelzxxvFkTty0mReAKsnrWA5Ri4Ppmz2AoazmBZgLvd96iaMB%2FFQETOSQ3PIFfHo5SaWbkQ9YARz%2FLg0kAUseSEXPwd2lAHm1A9pFKvJn8hvJdDAWVDvzLmk5%2Fy3%2F57%2F4fgpHZA4%2B%2F5vuoRvfjorphzFcweQAJb0kPsson2LxXzBo3DO3OGUJu7cOuj1fJoQJ2SvIl98dIUAx1V59nqAFuA7p44HaJETsuoRaNZ9HiTwfHgOsrLGxHLC0Geug%2Fwa%2FRnzwBr01hnwitCFw%2FwByCaOr3jkAa4nGe96PY%2FGbsQmgOUpSnJA%2Bgfk5LZaaEKnPKKnvt934mXgVp5hy1aAmS5p9OrlUzG3c%2BWwZJPp%2FRV5%2B9ZjETJ0IB6OAdDnruOPyRTkRQF2fZBPLXkDs727ucqnX4%2Bg%2B93G8lJ0%2BboVjdoYmtZnvLmSAHbE04TGNixQ65tJoaxLK0t7OyEBvarKrA9rSCqAGPHfmSY0MvOQTUkfbY5PM%2BuxvYkNYkkiviQnJyfEmqaBsAXroAQnphYU18H6qqtg57qCUiF0hTsZEsdbsICkwJkNJcCGKprwCxpUenBw3tGmK9hGI%2BI7wSwFd3CimFp5LqUEPitaopwWaSJ0ujKLz2csQN3tC70ekxs3V0qbbdGzvlHoeuVp1rm%2BsclHskGcbEhebaAQmafpFGtv9K979c8lLSpIjmgcwgdaaLFQJls58L5gyUEFUGB3kkPaOV%2Fsilhy4vRjq3Rn%2BiGITPpWPOep70mWg1aYBUs%2FhOCu%2B7iyzbwDmPYefUCnLKBe%2F8A4UrAMBz98nzp%2BvyJFLZTA1jS7Afk5OGsyZdT3YuG4PWAHAd%2FdSI%2BUitwaPeBcsXH%2BInfG20QhowFbkWL7GhClpTDDQ%2BmHgRZwgE4yIBH3aazcsVippyM6g%2BzA1WLdgqsWsjq2tONPo8hZ2iwW%2F%2FsCnQO5zHkEu8FSvwrg3gEX%2BNcgqbLACm%2F08uHZeZsr6uJnpA2JvbYP3l7uJesR%2BH3Yq9ejKYviBIKjGYvBNb8baIx8wr3lmPx29vyZDR6VBTM2XfZ1vkAZ%2FkD7KPM49afrg3qf2ubrDxY0mXPwZVbIIZirPl%2B3GkAY0UvcrDJ6gRjiiI1L8CHjc5sx1FzU52Qv0J7MWYyo3pVkTaiii3q2yxdWswAAfkaTIWznmoH7lIXOEnK3G8N2lsbSKvq3Dn9oFZ1wvCAs4evj1HVpHE9T31%2FuVV5ila%2FeCnT%2B20mcnPxcChgg97eR1PHhodbD4fR25y2p8HLA7xnsKmJL1ckvD7bGRHKdfCRp4MnZayPlbL%2BK7XwsN6fy8Mr4Lr6zYN8%2BNEis2l2LBHfNmoTNrE3YdBqFzahV2Jo0S07aM7CoUcM2QbIwrNCb2pCyMLORtXBuE52Sw3B8n19lDgPiHHcO4TYtUr8rBpSmiGqSRgGqVvao0aMUBAONqZ%2FkJGepRxoCqtQgVAasLRMGEaJeDkX4MhZZtX4UMmVsUDVsJZ%2BfUK08BRO7iblwDEC2Cm3PQIndREZXG3TVhV6dIMNNOoxXmZVuKEuDgKXgQMK5E5GyFtWH0YJ2F2NH015Qo10rm2qShW3bjZaHDesOPGL%2Fc6Tg30FsTm6uhH2s311LeNvuAti22wlKELmtFmmNKUJukO9O2UqJ1m0zlgJUL8RSJtMUneXZjX4QZDx6zwBZkPaBSEX0j16Xq29vxsRN44Qv4OuLiIc0SpZYlNNCJs7kKZsmpXqeflwaiKrfuTPJBz7CApV%2BtPVh6ItZh2iDw1nE09AChyf6HkHXY%2BwxwgJSQyFvgNEsfCY2TI26m5JGbFKgApNi2GtYTCL3BlSJvITeyPtFbsgDWPoi4FfBbcNcgGUxk51LADDdaS5JVRk3ZIPw1o3ImWyvS4pcGt45Tb4mzJbpNbbRCJVC6vQQy%2FOh0uohqgbWeqsVaXKJJWnLiLXGOAr8NcVtIy1CdTryV4xFfZMSLTEsgA6KKanExsw6MUWhaML%2BmjfNEvCG7ZXWl0%2FkbimNwThJ3VsY5lFWi3rdOBsyRFp6mSNL2qBAuanYLHD9FCzl3hK470Ao0XUKo08pTZDQD8lWM2wnjpZ6UWlkQ80IW3vgC1aFr3%2FkqxAR7RInIKcvfiUXdCm%2Fg83Cd7CDjlsqBEQwGHyVdXh0%2FMOtH3%2F6xz%2F%2FdXrv%2FoOHjx4%2FsUy%2BVxVnq0GyG1FzkLyf2Fcia461smKKRy%2Fv0g%2FOIvRpQ%2FUE216j6S8%2F%2BFQro8oMUew3VyjKO7Zk7Dcaj2qhJMWb%2BY7q7Z6uTAFzMEKV%2FDoB9sU0gUExrskiwfm9py1q4aFY9jpKtJ%2FsBNsnqjLsWWMU48DfNxW2dPi2it2lDJIb8MdpCHIZYsWgvfhcwq%2Bca9%2BxZWijyLKeUNgABgQ8le%2F9zdJw5Rr1ijuQ2JOPH4llcH77cd2SHlCPx5x7kyXNifmsHve73VzH01Z1clOQ2wYzeRVvQomMHbao0nWT915rtio5uYtxQseowjxCZEtj8tqiHkt4ZL3Zqd67Zw3F1uXwjRbTL1q7jxq1G4c9geA%2FyyL71oLGsTOj5qxBD%2BZxV%2Becs%2Ffm8FhWNgDYSAIMqk8sFLABGx2MsqnThtxHCydUc1trvqQRm2aJCZ8q6%2B5oz4K6c%2F4HziFSETHb8u5CRu87e4EwnYDqDkUZY8%2BuoILyd0dQxnR%2FjqDdqBvy05f6VzkQ6nkdclSrrDsGSn22wGN%2BR%2FqnYB5XT5jn0eCRqHePSRKlhiLr1ZxGtEmGSuvMA8QgTGHizrppENRWkdeKvC1bvgiqB1kflWcxC2HY4G%2Fi14dvjJLOAZWMxcFJo%2FeqL70ZzxuwLsO91HsRLWsMrmUk3RUEHXWMTBZmlmQHi8a2q3liM0geW5uZGsDNxqvjtSb2NFWn8HCpVOTv9vwX2fNYSmHTtscl4ShT165fE2HuBWr0So2pTKt0BFlt9AMFenL0s9T3W5L50rFw1%2BVpkJCn3L2Azd9wZqXgECqQeBmDcYoPQHmUYgBIouVTcc7ppCUWEsy6zkEUbFtGM4KLUhdzwswahq1UMJ04XpOTMUQs2L4CH1fXNmyjUalaw9ChlXyZLCHegrjk57rJ1dWj62klbPs9sSRW31FRumnHtdTi2pJrYOFWJ5qwaU41mTTjGb3KaxroGXaw8C%2FDtj%2BpUe%2BYjmD7svyBTtEqh1vdC5LMZQ1Y7oKgGJwsnGBJnCShizCJWxNkbFJlsn3EoKe1QQ1GsFt6JOG71IKxNQdT2LYJqLC1BlXYOgVWYqAKrjqaRoP6mOKuRhGIu2EXr4IEr0wIb32qVKJzziSoKG1G2QRZWK3XkxxCrd724qxFy9NA6LmjoigeuLSgjIQQxXGPsJjwyw7VIGzgRzEUq16%2BKrc9WsMWL02wdVf%2Btpch2HIujckDWNcO%2BBXwZUh%2BOvyR%2FJ0cHR4e7uTMvhErwat0KLqvPEr%2BvpPWwb9vTS3tm9%2BaNO8aKxCVrUmTzSsaDF8Nl43kewpIuWY8GeY3BiZLKZfGvQmc0fnzB8%2FH5CxcwhaX%2FwxATANP1gKyK8wVsK0vllVx%2B0RXlhouJZmUcxdvoVG9bW44FYk2UgF8z95T3aM0uA%2ByxGDl511vOTWqiDzA0%2BniiKrwqBRxw10Jab5Q02hkVClPmuqSTZGEciiVe8WdBOGx2Jn49KGEr7s2%2FXUz%2Fd2Y2uS24F8D3Z1pb6MfW1GO2rwGb%2FaKQl5bvbzC6DViHj0VVxRNu4EmR7TBSMDY%2B1QoD%2FKR%2B9SGyXgEfcZbeuoArOYgtUFzaQDqBqG3IxDEhZKI%2B%2BirMANdUCJ%2B6qGDLm93srN9z22Sn7gH%2FTzwl2KTRbciLkbHFNYzRQ%2FZSQwGBu6mEc2qr%2FrR3U535q9gxfq6N7Drjvbx2W%2Bk7pETf%2BVl1fpwIYr%2F7H6GtmVH04fORY1PFz%2FXlMDG09h9tFdhTvBf0aO9TqsoUqdPK6pfOqteMYENRnZMV%2FF8X9pyru96htvhzEIni5Hgn1vKShB3PpmkM7JMotbfKjD%2BagQe75fn%2BWu%2FrVMKXYqrAZRcMkf4fZdHESCUXxDo%2BFMIYj%2F%2BXf1KTaccrLKdg%2ByGsNrmjq5Xgde42NFArHn8RqUXcnGRXuhg1C8FmLUmw2Akj7cfgyHoK%2Btb6k8278bx%2BeOW4%2FN7CJ8bVVCng4pHhmPuZay1YpnKF5zd%2BHv0LfBXy0VkQymNKLPw1uEtne3C3%2F8BPD4jor1OAAA%3D&config=H4sIAAAAAAAAA1WOwQqAIAyG7z6F7NwhPPY2YiOKTNkWFNG7pyaFu%2B3j%2B7f%2FUjoNLOxg0FdZCoiWGKlhhfO5iT0SBzkjsqM5CnStI5wFoR0%2Ffv8KiKUJJZ9ANr0xNV4V8GHcV2zb5F854IL3YVsY3oS6H7C3Cli%2FAAAA

See saveToJWTKey

Correct: https://play.swc.rs/?version=1.3.94-nightly-20231015.1&code=H4sIAAAAAAAAA%2B0ca5PTOPJ7foWOosqZq8SZmWX37rI7wPDePQ5YZtj7QFHg2EqiHccyfsyQC%2Fnv1y3Jr1iynUxggUI1VZPIaqnf6m5LYYuQRwlZkceRE85%2Ff3rfZzRIyJpMI74g1gx73%2FvDiL5PaZxYPSbH%2F3mVPKAu96gaB9%2BHnuiwetmYZBlSmPhVTKN8PtsewV%2FouBfOjMbwYelzxxvFkTty0mReAKsnrWA5Ri4Ppmz2AoazmBZgLvd96iaMB%2FFQETOSQ3PIFfHo5SaWbkQ9YARz%2FLg0kAUseSEXPwd2lAHm1A9pFKvJn8hvJdDAWVDvzLmk5%2Fy3%2F57%2F4fgpHZA4%2B%2F5vuoRvfjorphzFcweQAJb0kPsson2LxXzBo3DO3OGUJu7cOuj1fJoQJ2SvIl98dIUAx1V59nqAFuA7p44HaJETsuoRaNZ9HiTwfHgOsrLGxHLC0Geug%2Fwa%2FRnzwBr01hnwitCFw%2FwByCaOr3jkAa4nGe96PY%2FGbsQmgOUpSnJA%2Bgfk5LZaaEKnPKKnvt934mXgVp5hy1aAmS5p9OrlUzG3c%2BWwZJPp%2FRV5%2B9ZjETJ0IB6OAdDnruOPyRTkRQF2fZBPLXkDs727ucqnX4%2Bg%2B93G8lJ0%2BboVjdoYmtZnvLmSAHbE04TGNixQ65tJoaxLK0t7OyEBvarKrA9rSCqAGPHfmSY0MvOQTUkfbY5PM%2BuxvYkNYkkiviQnJyfEmqaBsAXroAQnphYU18H6qqtg57qCUiF0hTsZEsdbsICkwJkNJcCGKprwCxpUenBw3tGmK9hGI%2BI7wSwFd3CimFp5LqUEPitaopwWaSJ0ujKLz2csQN3tC70ekxs3V0qbbdGzvlHoeuVp1rm%2BsclHskGcbEhebaAQmafpFGtv9K979c8lLSpIjmgcwgdaaLFQJls58L5gyUEFUGB3kkPaOV%2Fsilhy4vRjq3Rn%2BiGITPpWPOep70mWg1aYBUs%2FhOCu%2B7iyzbwDmPYefUCnLKBe%2F8A4UrAMBz98nzp%2BvyJFLZTA1jS7Afk5OGsyZdT3YuG4PWAHAd%2FdSI%2BUitwaPeBcsXH%2BInfG20QhowFbkWL7GhClpTDDQ%2BmHgRZwgE4yIBH3aazcsVippyM6g%2BzA1WLdgqsWsjq2tONPo8hZ2iwW%2F%2FsCnQO5zHkEu8FSvwrg3gEX%2BNcgqbLACm%2F08uHZeZsr6uJnpA2JvbYP3l7uJesR%2BH3Yq9ejKYviBIKjGYvBNb8baIx8wr3lmPx29vyZDR6VBTM2XfZ1vkAZ%2FkD7KPM49afrg3qf2ubrDxY0mXPwZVbIIZirPl%2B3GkAY0UvcrDJ6gRjiiI1L8CHjc5sx1FzU52Qv0J7MWYyo3pVkTaiii3q2yxdWswAAfkaTIWznmoH7lIXOEnK3G8N2lsbSKvq3Dn9oFZ1wvCAs4evj1HVpHE9T31%2FuVV5ila%2FeCnT%2B20mcnPxcChgg97eR1PHhodbD4fR25y2p8HLA7xnsKmJL1ckvD7bGRHKdfCRp4MnZayPlbL%2BK7XwsN6fy8Mr4Lr6zYN8%2BNEis2l2LBHfNmoTNrE3YdBqFzahV2Jo0S07aM7CoUcM2QbIwrNCb2pCyMLORtXBuE52Sw3B8n19lDgPiHHcO4TYtUr8rBpSmiGqSRgGqVvao0aMUBAONqZ%2FkJGepRxoCqtQgVAasLRMGEaJeDkX4MhZZtX4UMmVsUDVsJZ%2BfUK08BRO7iblwDEC2Cm3PQIndREZXG3TVhV6dIMNNOoxXmZVuKEuDgKXgQMK5E5GyFtWH0YJ2F2NH015Qo10rm2qShW3bjZaHDesOPGL%2Fc6Tg30FsTm6uhH2s311LeNvuAti22wlKELmtFmmNKUJukO9O2UqJ1m0zlgJUL8RSJtMUneXZjX4QZDx6zwBZkPaBSEX0j16Xq29vxsRN44Qv4OuLiIc0SpZYlNNCJs7kKZsmpXqeflwaiKrfuTPJBz7CApV%2BtPVh6ItZh2iDw1nE09AChyf6HkHXY%2BwxwgJSQyFvgNEsfCY2TI26m5JGbFKgApNi2GtYTCL3BlSJvITeyPtFbsgDWPoi4FfBbcNcgGUxk51LADDdaS5JVRk3ZIPw1o3ImWyvS4pcGt45Tb4mzJbpNbbRCJVC6vQQy%2FOh0uohqgbWeqsVaXKJJWnLiLXGOAr8NcVtIy1CdTryV4xFfZMSLTEsgA6KKanExsw6MUWhaML%2BmjfNEvCG7ZXWl0%2FkbimNwThJ3VsY5lFWi3rdOBsyRFp6mSNL2qBAuanYLHD9FCzl3hK470Ao0XUKo08pTZDQD8lWM2wnjpZ6UWlkQ80IW3vgC1aFr3%2FkqxAR7RInIKcvfiUXdCm%2Fg83Cd7CDjlsqBEQwGHyVdXh0%2FMOtH3%2F6xz%2F%2FdXrv%2FoOHjx4%2FsUy%2BVxVnq0GyG1FzkLyf2Fcia461smKKRy%2Fv0g%2FOIvRpQ%2FUE216j6S8%2F%2BFQro8oMUew3VyjKO7Zk7Dcaj2qhJMWb%2BY7q7Z6uTAFzMEKV%2FDoB9sU0gUExrskiwfm9py1q4aFY9jpKtJ%2FsBNsnqjLsWWMU48DfNxW2dPi2it2lDJIb8MdpCHIZYsWgvfhcwq%2Bca9%2BxZWijyLKeUNgABgQ8le%2F9zdJw5Rr1ijuQ2JOPH4llcH77cd2SHlCPx5x7kyXNifmsHve73VzH01Z1clOQ2wYzeRVvQomMHbao0nWT915rtio5uYtxQseowjxCZEtj8tqiHkt4ZL3Zqd67Zw3F1uXwjRbTL1q7jxq1G4c9geA%2FyyL71oLGsTOj5qxBD%2BZxV%2Becs%2Ffm8FhWNgDYSAIMqk8sFLABGx2MsqnThtxHCydUc1trvqQRm2aJCZ8q6%2B5oz4K6c%2F4HziFSETHb8u5CRu87e4EwnYDqDkUZY8%2BuoILyd0dQxnR%2FjqDdqBvy05f6VzkQ6nkdclSrrDsGSn22wGN%2BR%2FqnYB5XT5jn0eCRqHePSRKlhiLr1ZxGtEmGSuvMA8QgTGHizrppENRWkdeKvC1bvgiqB1kflWcxC2HY4G%2Fi14dvjJLOAZWMxcFJo%2FeqL70ZzxuwLsO91HsRLWsMrmUk3RUEHXWMTBZmlmQHi8a2q3liM0geW5uZGsDNxqvjtSb2NFWn8HCpVOTv9vwX2fNYSmHTtscl4ShT165fE2HuBWr0So2pTKt0BFlt9AMFenL0s9T3W5L50rFw1%2BVpkJCn3L2Azd9wZqXgECqQeBmDcYoPQHmUYgBIouVTcc7ppCUWEsy6zkEUbFtGM4KLUhdzwswahq1UMJ04XpOTMUQs2L4CH1fXNmyjUalaw9ChlXyZLCHegrjk57rJ1dWj62klbPs9sSRW31FRumnHtdTi2pJrYOFWJ5qwaU41mTTjGb3KaxroGXaw8C%2FDtj%2BpUe%2BYjmD7svyBTtEqh1vdC5LMZQ1Y7oKgGJwsnGBJnCShizCJWxNkbFJlsn3EoKe1QQ1GsFt6JOG71IKxNQdT2LYJqLC1BlXYOgVWYqAKrjqaRoP6mOKuRhGIu2EXr4IEr0wIb32qVKJzziSoKG1G2QRZWK3XkxxCrd724qxFy9NA6LmjoigeuLSgjIQQxXGPsJjwyw7VIGzgRzEUq16%2BKrc9WsMWL02wdVf%2Btpch2HIujckDWNcO%2BBXwZUh%2BOvyR%2FJ0cHR4e7uTMvhErwat0KLqvPEr%2BvpPWwb9vTS3tm9%2BaNO8aKxCVrUmTzSsaDF8Nl43kewpIuWY8GeY3BiZLKZfGvQmc0fnzB8%2FH5CxcwhaX%2FwxATANP1gKyK8wVsK0vllVx%2B0RXlhouJZmUcxdvoVG9bW44FYk2UgF8z95T3aM0uA%2ByxGDl511vOTWqiDzA0%2BniiKrwqBRxw10Jab5Q02hkVClPmuqSTZGEciiVe8WdBOGx2Jn49KGEr7s2%2FXUz%2Fd2Y2uS24F8D3Z1pb6MfW1GO2rwGb%2FaKQl5bvbzC6DViHj0VVxRNu4EmR7TBSMDY%2B1QoD%2FKR%2B9SGyXgEfcZbeuoArOYgtUFzaQDqBqG3IxDEhZKI%2B%2BirMANdUCJ%2B6qGDLm93srN9z22Sn7gH%2FTzwl2KTRbciLkbHFNYzRQ%2FZSQwGBu6mEc2qr%2FrR3U535q9gxfq6N7Drjvbx2W%2Bk7pETf%2BVl1fpwIYr%2F7H6GtmVH04fORY1PFz%2FXlMDG09h9tFdhTvBf0aO9TqsoUqdPK6pfOqteMYENRnZMV%2FF8X9pyru96htvhzEIni5Hgn1vKShB3PpmkM7JMotbfKjD%2BagQe75fn%2BWu%2FrVMKXYqrAZRcMkf4fZdHESCUXxDo%2BFMIYj%2F%2BXf1KTaccrLKdg%2ByGsNrmjq5Xgde42NFArHn8RqUXcnGRXuhg1C8FmLUmw2Akj7cfgyHoK%2Btb6k8278bx%2BeOW4%2FN7CJ8bVVCng4pHhmPuZay1YpnKF5zd%2BHv0LfBXy0VkQymNKLPw1uEtne3C3%2F8BPD4jor1OAAA%3D&config=H4sIAAAAAAAAA1WOwQqAIAyG7z6F7NwhPPY2YiOKTNkWFNG7pyaFu%2B3j%2B7f%2FUjoNLOxg0FdZCoiWGKlhhfO5iT0SBzkjsqM5CnStI5wFoR0%2Ffv8KiKUJJZ9ANr0xNV4V8GHcV2zb5F854IL3YVsY3oS6H7C3Cli%2FAAAA

kdy1 added a commit to kdy1/swc that referenced this pull request Oct 19, 2023
@kdy1
Revert "fix(es/utils): Skip var declarator name in RefRewriter (swc…
7884fd6 
…-project#8125)"

This reverts commit fb81a36.
@magic-akari
Copy link
Member Author 

                const {
                    collection,
                    email: jwtEmail,
                    exp,
                    iat,
                    roles,
                    [saveToJWTKey]: customJWTPropertyKey,
                    tabLiftedSaveToJWT,
                    unnamedTabSaveToJWTFalse,
                    'x-lifted-from-group': liftedFromGroup,
                    'x-tab-field': unnamedTabSaveToJWTString,
                } = decoded

Yes, the saveToJWTKey is ident ref

@kdy1 kdy1 modified the milestones: Planned, v1.3.94 Oct 21, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot

@kdy1 kdy1

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.94
Development

Successfully merging this pull request may close these issues.

[TypeScript] Invalid code generated of var declaration which shares the name of exported binding
3 participants
@magic-akari @kdy1 @swc-bot