Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Abort seq inliner if b can short-circuit #8128

Merged
merged 16 commits into from
Oct 18, 2023
Merged

fix(es/minifier): Abort seq inliner if b can short-circuit #8128

merged 16 commits into from
Oct 18, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 16, 2023

@kdy1 kdy1 added this to the Planned milestone Oct 16, 2023
@kdy1 kdy1 self-assigned this Oct 16, 2023
@kdy1 kdy1 changed the title fix(es/minifier): Fix a bug fix(es/minifier): Fix a bug related to logical assignments Oct 16, 2023
@kdy1 kdy1 changed the title fix(es/minifier): Fix a bug related to logical assignments fix(es/minifier): Abort seq inliner if b can short-circuit Oct 16, 2023
@kdy1 kdy1 marked this pull request as ready for review October 16, 2023 07:18
kdy1
kdy1 commented Oct 16, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

@kdy1 kdy1 requested a review from jridgewell October 16, 2023 07:19
@kdy1 kdy1 enabled auto-merge (squash) October 18, 2023 02:26
swc-bot
swc-bot reviewed Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 111de26 into swc-project:main Oct 18, 2023
143 checks passed
@kdy1 kdy1 deleted the issue-8119 branch October 18, 2023 03:44
@kdy1 kdy1 removed this from the Planned milestone Oct 21, 2023
@kdy1 kdy1 added this to the v1.3.94 milestone Oct 21, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@jridgewell jridgewell jridgewell approved these changes

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.94
Development

Successfully merging this pull request may close these issues.

Compression misplaces function call when variable storing return value is used for logical assignment
3 participants
@kdy1 @jridgewell @swc-bot