Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(es/parser): Implement AsRef<str> for IdentLike #8133

Merged
merged 2 commits into from
Oct 18, 2023
Merged

feat(es/parser): Implement AsRef<str> for IdentLike #8133

merged 2 commits into from
Oct 18, 2023

Conversation

dsherret
Copy link
Contributor

Description: This is a new type and it's helpful to be able to easily get a string from it.

kdy1
kdy1 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_parser

@kdy1 kdy1 added this to the Planned milestone Oct 18, 2023
@kdy1 kdy1 changed the title feat(ecma_parser): IdentLike - implement AsRef<str> feat(es/parser): Implement AsRef<str> for IdentLike Oct 18, 2023
@kdy1 kdy1 enabled auto-merge (squash) October 18, 2023 02:27
swc-bot
swc-bot reviewed Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit bffe33a into swc-project:main Oct 18, 2023
143 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.94 Oct 21, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.94
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dsherret @kdy1 @swc-bot