Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(es/compat): Skip empty class static blocks #8138

Merged
merged 3 commits into from
Oct 18, 2023
Merged

feat(es/compat): Skip empty class static blocks #8138

merged 3 commits into from
Oct 18, 2023

Conversation

magic-akari
Copy link
Member

@magic-akari magic-akari commented Oct 18, 2023 •
edited by kdy1

Description:

And, update the static_block_private_id generate rules to be consistent with Babel.

Related issue:

@magic-akari magic-akari marked this pull request as ready for review October 18, 2023 08:14
kdy1
kdy1 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_ecma_compat_es2022

@kdy1 kdy1 changed the title fix(es/compat): Skip empty class static blocks feat(es/compat): Skip empty class static blocks Oct 18, 2023
@kdy1 kdy1 enabled auto-merge (squash) October 18, 2023 17:57
@kdy1 kdy1 merged commit e186b80 into swc-project:main Oct 18, 2023
144 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.94 Oct 18, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 20, 2023
@magic-akari magic-akari deleted the fix/issue-8136 branch December 5, 2023 03:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.94
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@magic-akari @kdy1