Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Abort function inliner if keep_fnames is true #8145

Merged
merged 21 commits into from
Oct 19, 2023
Merged

fix(es/minifier): Abort function inliner if keep_fnames is true #8145

merged 21 commits into from
Oct 19, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 18, 2023

@kdy1 kdy1 added this to the Planned milestone Oct 18, 2023
@kdy1 kdy1 self-assigned this Oct 18, 2023
@kdy1
Copy link
Member Author

kdy1 commented Oct 18, 2023

Investigation

This is a bug of name mangler. ie points to different ie when the mangler is enalbed.

@kdy1 kdy1 changed the title fix(es/minifier): Fix a bug of minifier fix(es/minifier): Abort function inliner if keep_fnames is true Oct 19, 2023
@kdy1 kdy1 marked this pull request as ready for review October 19, 2023 00:15
@kdy1 kdy1 enabled auto-merge (squash) October 19, 2023 00:15
kdy1
kdy1 commented Oct 19, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 19, 2023
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 19, 2023
View reviewed changes
@kdy1 kdy1 requested a review from jridgewell October 19, 2023 15:42
kdy1
kdy1 commented Oct 19, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

@kdy1 kdy1 marked this pull request as draft October 19, 2023 16:34
auto-merge was automatically disabled October 19, 2023 16:34

Pull request was converted to draft

@kdy1
Copy link
Member Author

kdy1 commented Oct 19, 2023

Marking as draft because it fixes the bug but the size regression looks too much.

default: 89197 bytes
new: 99631 bytes

@kdy1
Copy link
Member Author

kdy1 commented Oct 19, 2023 

default (total): 8978108 bytes
new (total): 9535588 bytes

@kdy1 kdy1 marked this pull request as ready for review October 19, 2023 16:45
@kdy1 kdy1 enabled auto-merge (squash) October 19, 2023 18:57
swc-bot
swc-bot reviewed Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 35601e4 into swc-project:main Oct 19, 2023
281 checks passed
@kdy1 kdy1 deleted the next-56408 branch October 19, 2023 20:20
@kdy1 kdy1 modified the milestones: Planned, v1.3.94 Oct 21, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@jridgewell jridgewell jridgewell approved these changes

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.94
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kdy1 @jridgewell @swc-bot