fix(es/utils): Fix regression of RefRewriter

[kdy1]

Description:

Related issue:

• Found while invetigating https://github.com/swc-project/swc-ecosystem-ci/actions/runs/6581045465/job/17880208108

[kdy1]

cc @magic-akari Can you take a look?

[kdy1]

swc-bump:

• swc_ecma_utils

[kdy1]

cc @magic-akari Is this the correct fix?

[magic-akari]

swc/crates/swc_ecma_utils/src/lib.rs

Lines 3070 to 3079 in cea140e

	fn visit_mut_pat(&mut self, n: &mut Pat) {
	match n {
	Pat::Ident(BindingIdent { id, .. }) => {
	if let Some(expr) = self.query.query_lhs(id) {
	*n = Pat::Expr(Box::new(expr));
	}
	}
	_ => n.visit_mut_children_with(self),
	}
	}

The key issue here is that we hope that when we access Pat::Ident, we get the Ident ref, not the ident decl

var a = "value-a", b = "value-b"; // var declaration
//  ^^^ decl       ^^^ decl

var { [a]: d, c } = { "value-a": 1, b }; // var declaration
//     |   |  ^^^ decl              ^^^ ref
//     |   |- decl
//     |
//     |-- ref

var [e = a] =     [a];       // var declaration
//   |   ^^^ ref   ^^^ ref
//   |- decl

  [b] = [1], { [a]:    d } = { "value-a": 1 }; // assignment expression
// ^^^ ref      ^^ref  ^^ref

I think that the Pat in a declaration name and the Pat in an assignment expression are different.
In an assignment expression, Pat::Ident can be safely replaced with Pat::Expr,
but you can't do that in a declaration name.

Maybe we should wrap all ident ref cases in an IdentRef struct #8074.

[swc-bot]

Automated review comment generated by auto-rebase script